Fix issue #10 #11
Fix issue #10 #11
Conversation
| UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"LumberjackConsole" bundle:[NSBundle bundleForClass:[self class]]]; | ||
| self.rootViewController = [storyboard instantiateInitialViewController]; | ||
There was a problem hiding this comment.
Looks good. Just what happened to the indentation?
There was a problem hiding this comment.
Sorry, probably we are using different indentation settings
There was a problem hiding this comment.
Yes, probably mines are the default ones. Could you just fix them so I can merge it?
There was a problem hiding this comment.
Should be ok now, the problem is that it is perfectly indented in my Xcode.
Xcode automatically align the indentation
|
Seems that your problem is that your indentation uses tabs instead of spaces, so depending on the editor it will always look off (the reason why tabs are discouraged. |
|
Is the last commit still not good? |
| (UIInterfaceOrientationIsPortrait(currentOrientation) && UIInterfaceOrientationIsLandscape(nextOrientation))) | ||
| { | ||
| frame.size = CGSizeMake(frame.size.height,frame.size.width); | ||
| } |
There was a problem hiding this comment.
Drag your mouse in your indentation code here and you'll notice that it indents with either tab for each level.
Regular Xcode indentation (so this and most iOS/OSX projects) uses four spaces for each level of indentation.
You can take a look here at how to change the setting and some discussion about indentation ;)
There was a problem hiding this comment.
Also you can see here how your edits don't look indented in GitHub (and so in many editors that don't represent a tab with four spaces).
|
What do you think about the last commit? Is it aligned? |
|
Yes, looks really good now ;) Thanks for you time. |
Fix the crash when using cocoapods framework, see #10