Fix view controller containment issues in Titanium #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radazzouz
approved these changes
Apr 22, 2020
karolkulesza
added a commit
to PitcherAG/Appcelerator-iOS
that referenced
this pull request
Apr 22, 2020
…y PSPDFKit support team: PSPDFKit#36); Addressing the issue: https://basecamp.com/2001839/projects/16945828/todos/415872076;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts a band-aid over tidev/titanium-sdk#11651 and fixes the view controller containment among the ancestors of
PSPDFViewController. Not fulfilling the requirements of view controller containment causes issues with view controller ownership and presentation, especially on iOS 12.In addition, this PR updates README with up-to-date installation steps and adds Node.js artifacts to gitignore to enable local installation of required tools.