Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 [Patch]: Update argument completer to support Get-Font #36

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Feb 13, 2025

Description

This pull request includes changes to the PowerShell scripts for font management. The most important changes involve the consolidation of argument completers and the removal of redundant code.

Consolidation of argument completers:

  • src/functions/completers.ps1: Added a new argument completer for the Uninstall-Font and Get-Font commands to handle the Name parameter. This script block checks the Scope parameter and filters font names based on the user's input.

Removal of redundant code:

  • src/functions/public/Uninstall-Font.ps1: Removed the previously defined argument completer for the Uninstall-Font command, as it has been consolidated into the new script block in completers.ps1.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner February 13, 2025 12:42
@MariusStorhaug MariusStorhaug self-assigned this Feb 13, 2025
@MariusStorhaug MariusStorhaug merged commit b746cb0 into main Feb 14, 2025
20 checks passed
@MariusStorhaug MariusStorhaug deleted the RegArgCom branch February 14, 2025 07:41
Copy link

Module Fonts - v1.1.14 published to the PowerShell Gallery.

Copy link

GitHub release for Fonts v1.1.14 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant