-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Age Variable Counts to SAS Scripts #183
Move Age Variable Counts to SAS Scripts #183
Conversation
I've added some checks in the SAS scripts to ensure that |
@andersonfrailey said:
That's great! Thanks for the quick resolution of this issue. |
@andersonfrailey, Do you think the changes in pull request #183 will resolve issue #149? |
@martinholmer, the issue in #149 was resolved in PR #151 for the CPS file. I'm still working on a fix for the PUF. This PR was aimed at resolving just #157. |
@andersonfrailey said:
OK. Thanks for the clarification. |
Updated this PR now that #184 has been merged. Ready to go upon review. |
@andersonfrailey said:
I'm not conversant with SAS. Are you going to ask @Amy-Xu to review #183? |
@Amy-Xu can review the code and anyone should be able to download the individual CSV files to look through if they so choose. |
If there are no additional comments I'll merge this at the end of the work day. |
Sorry for the delay. Looks good to me. |
This PR moves the creation of
nu13
,nu05
,n24
,elderly_dependent
,f2441
, andEIC
for the CPS file fromfinalprep.py
to the SAS scripts. I'm doing this because final prep was only able to count up to five dependents for each of these variables, while in the SAS scripts we should be able to catch all of them.It is labeled WIP because
n24
exceedsnu18
in about 7% of the records still. I'll remove the label when I figure out why this is the case. I also incrementedEIC
incorrectly for 2013 and 2014, which I'll fix in my next commit.