Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR 121 for minor bug fixes and completion of updates #122

Conversation

andersonfrailey
Copy link
Collaborator

This PR updates PR #121 by @Jennydeng123 to fix a few minor bugs in her code. Information about these updates can be found in that PR's first comment. I've opened this PR rather than working off of @Jennydeng123's is so that we can get it reviewed and merged quickly now that the newest Republican tax plan has been released.

@andersonfrailey andersonfrailey changed the title Update PR 121 for minor bug fixes Update PR 121 for minor bug fixes and completion of updates Nov 3, 2017
@andersonfrailey
Copy link
Collaborator Author

Latest commits update the grow factors, weights, and stage 3 adjustment factors. Working on a notebook to compare our current PUF, weights, and growth factors to the ones produced in this PR.

@andersonfrailey
Copy link
Collaborator Author

Here is the first version of the notebook. I'll be adding 2027 projections for the new calculator in the morning, but everything up to that point looks pretty similar to our current PUF.

@MattHJensen
Copy link
Contributor

cc @codykallen

@andersonfrailey
Copy link
Collaborator Author

I'm having trouble adding 2027 calculations to the notebook. Things get a little thrown off when you try to add a year to the extrapolation and compare with the current files.

When I make the needed updates to Tax-Calculator and run it with the new files. Working on updating all of the tests in tax-calculator then will open a corresponding PR.

@andersonfrailey
Copy link
Collaborator Author

Now that Tax-Calculator PR #1624 has been merged, I will also be merging this PR. Thanks again @Jennydeng123 for getting this started!

@andersonfrailey andersonfrailey merged commit 2a05532 into PSLmodels:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants