You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm raising this issue in order to facilitate a discussion about what should be on our short-term to-do list.
@andersonfrailey and I are in agreement that we will stage recent and pending data enhancements, so that 0.20.2 incorporates all the enhancements except the switch to the new CBO projection, which is pending in PR #180. Then the new CBO projections will be incorporated in Tax-Calculator release 0.20.3. This two-stage approach will provide a clear notion about how much results change from the data fixes and how much they change because of the projection update.
So, the question for discussion here is what enhancements need to be done for 0.20.2?
Here are some candidate enhancements for discussion:
Revise tests/test_benefit.py in light of actuarial values of health insurance amounts.
Figure out why there is one PUF record that has zero weight in every year (see code in tests/test_weights.py) and (presumably?) eliminate this filing unit from the PUF files. Investigated in PUF record with zero weight #239 but filing unit is not being eliminated from PUF files
Complete the work in tests/test_extrapolation.py so that we don't have to skip these tests.
Are there other items that should be added to the list?
Are there items that you think should not be on the list?
Which items do you volunteer to be responsible for?
On this last question, I'm happy to continue working on the Makefile and reduce the target precision and revise the benefit test after PR #185 is merged, but I can't make much more progress on the Makefile until the cps_stage4/extrapolation.py script is working.
@martinholmer, I think you've listed everything that should be done before the taxcalc 0.20.2 release.
The IRS recently released 2015 SOI data (we currently use 2014 data in our targeting), but that update can wait until we also implement the CBO updates.
I can look into the PUF weight with zero weight.
@hdoupe can you take a look at the benefit extrapolation scripts?
@martinholmer with regards to point 2, since PR #233 has already been merged hasn't that already been staged to be included in the release?
with regards to point 2 ["Reduce precision of stage2 targets (in the CSV files) so that the LP calculations are not triggered by tiny changes in the targets (as discussed in PR #233)"], since PR #233 has already been merged hasn't that already been staged to be included in the release?
PR #233 did not change the precision of the target amounts. Point 2 would add something like this format statement to the to_csv calls that write the two target CSV files:
I'm raising this issue in order to facilitate a discussion about what should be on our short-term to-do list.
@andersonfrailey and I are in agreement that we will stage recent and pending data enhancements, so that 0.20.2 incorporates all the enhancements except the switch to the new CBO projection, which is pending in PR #180. Then the new CBO projections will be incorporated in Tax-Calculator release 0.20.3. This two-stage approach will provide a clear notion about how much results change from the data fixes and how much they change because of the projection update.
So, the question for discussion here is what enhancements need to be done for 0.20.2?
Here are some candidate enhancements for discussion:
Finish
Makefile
development and documentation.Progress on this point in Eliminate redundant puf_stage1/Stage_I_factors_transpose.csv file #237 and Update taxdata/README.md info and csvcopy.sh script #238 and Add re-zip logic to taxdata Makefile #240
Reduce precision of stage2 targets (in the CSV files) so that the LP calculations are not triggered by tiny changes in the targets (as discussed in PR Makefile revisions: add puf-files target and add cps-files target #233).
Completed in Standardize float precision in various CSV files #236
Merge PR Update Medicare and Medicaid values in cps.csv.gz file #185 that converts health insurance amounts to actuarial values of the insurance.
Revise
tests/test_benefit.py
in light of actuarial values of health insurance amounts.Figure out why there is one PUF record that has zero weight in every year (see code in
tests/test_weights.py
) and (presumably?) eliminate this filing unit from the PUF files.Investigated in PUF record with zero weight #239 but filing unit is not being eliminated from PUF files
Revise
cps_stage4/extrapolation.py
so that it runs to completion and produces sensible output.How best to resolve this is being discussed in Benefits extrapolation script does not work #232
Completed in PR Revise cps_stage4/extrapolation.py script #242
Complete the work in
tests/test_extrapolation.py
so that we don't have to skip these tests.Are there other items that should be added to the list?
Are there items that you think should not be on the list?
Which items do you volunteer to be responsible for?
On this last question, I'm happy to continue working on the
Makefile
and reduce the target precision and revise the benefit test after PR #185 is merged, but I can't make much more progress on theMakefile
until thecps_stage4/extrapolation.py
script is working.@andersonfrailey @hdoupe @MattHJensen
The text was updated successfully, but these errors were encountered: