multiyear_diagnostic_table utils function in test_pufcsv.py #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.12% (diff: 100%)@@ master #864 diff @@
==========================================
Files 13 13
Lines 1816 1816
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1782 1782
Misses 34 34
Partials 0 0
|
|
No comments and this fixes a bug that is breaking requires_puf tests on master, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#848 and #852 moved diagnostic table capabilities from calculator methods to utils functions.
#844 added a new test
test_sample.py, which called the old calculator methods.Due to timing issues of when the PRs were merged, the changes from #848 and #852 weren't incorporated into #844.
@talumbau, could you please merge if everything looks good to you.