Fix two bugs in Behavior._update_ordinary_income method #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.08% (diff: 100%)@@ master #846 diff @@
==========================================
Files 13 13
Lines 1777 1777
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1743 1743
Misses 34 34
Partials 0 0
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two bugs found in the Behavior class _update_ordinary_income method by @codykallen in pull request #824. These bug fixes have been moved out of pull request #824 for two reasons. First, #824 contains a massive number of changes to an iPython notebook that has nothing to do with fixing the bugs. And second, the proposed fix of the bugs in #824 was confusing because the documentation was not changed to reflect the new logic and because the #824 code caused a pylint error.
Thanks to @codykallen for finding these bugs and suggesting sensible logic changes to fix them.
@MattHJensen @feenberg @Amy-Xu @GoFroggyRun @zrisher