Various fixes on tests #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test that assert the raise of an Exception contain 'raise' in name - remove 'test_make_Calculator_from_files' since it is identical to following test. There is no longer a 'from_files' class method so the test should have been removed.
|
looking to merge this soon... Any objections? |
|
On naming: it makes sense to me to keep the naming scheme consistent across tests for now (by making this change) and then to review the naming scheme more systematically when we proceed with the second step of our code style review #30 (comment). On removing the "from_file" test, that makes sense as well. 👍 @martinholmer, could you look this over and merge it if all seems good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following test. There is no longer a 'from_files' class method
so the test should have been removed.