Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct AMT taxable income calculation to handle QBID correctly #2784

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jul 27, 2024

The AMT function in calcfunctions.py is incorrectly calculating alternative minimum taxable income because it is not subtracting the qualified business income deduction (QBID). That it should be subtracted is clear from Form 1040 and Form 6251.

Form 6251 begins this way:

Screenshot 2024-07-27 at 12 47 27 PM

.

And line 15 on Form 1040 is calculated by subtracting the QBID:

Screenshot 2024-07-27 at 12 49 22 PM

.

This subtraction of QBID is not being done in Tax-Calculator 4.2.0.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (0b775e5) to head (57b5e18).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2784   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2613     2613           
=======================================
  Hits         2598     2598           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martinholmer martinholmer marked this pull request as draft July 27, 2024 19:02
@martinholmer martinholmer marked this pull request as ready for review July 27, 2024 19:22
@jdebacker
Copy link
Member

@martinholmer Thanks for finding and fixing this bug. Merging.

@jdebacker jdebacker merged commit d36d8db into PSLmodels:master Jul 28, 2024
11 checks passed
@martinholmer martinholmer deleted the fix-amt-wrt-qbid branch July 28, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants