Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exact calculation logic to CTC_new function #2769

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jul 8, 2024

Add exact, stair-step phase-out logic when exact is one in the CTC_new (i.e., ARPA CTC addition) function. This change affects tax results only when CTC_new is active (which is only during 2021 under current-law policy) and when the exact_calculations argument of the Records class constructor has been specified to be True.

@martinholmer martinholmer marked this pull request as draft July 8, 2024 17:53
@martinholmer martinholmer changed the title Add exact calculation logic in CTC_new (ie, ARPA CTC addition) function Add exact calculation logic to CTC_new function Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (9a8cbfd) to head (3779d50).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2769   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2610     2610           
=======================================
  Hits         2595     2595           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martinholmer martinholmer marked this pull request as ready for review July 8, 2024 18:33
@martinholmer martinholmer merged commit 9b758a0 into PSLmodels:master Jul 8, 2024
11 checks passed
@martinholmer martinholmer deleted the fix-arpa-ctc-phaseout branch August 4, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant