Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise ppp.py script so that it does not crash #2725

Merged
merged 6 commits into from
Mar 17, 2024

Conversation

martinholmer
Copy link
Collaborator

This pull request refactors the ppp.py script so that it does not stop with a fatal error. The refactoring does not change the logic of the ppp.py script.

Also, I added decimal points to the new float parameter recently added because ParamTools writes this parameter's values as floats (instead of integers). These changes are purely cosmetic, but will avoid spurious changes to the policy_current_law.json file when the ppp.py script is executed.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (598f1d6) to head (a8ac3d0).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2725      +/-   ##
==========================================
+ Coverage   98.54%   99.42%   +0.87%     
==========================================
  Files          14       13       -1     
  Lines        2616     2593      -23     
==========================================
  Hits         2578     2578              
+ Misses         38       15      -23     
Flag Coverage Δ
unittests 99.42% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@martinholmer martinholmer marked this pull request as draft March 15, 2024 19:18
@martinholmer martinholmer marked this pull request as ready for review March 16, 2024 13:57
@jdebacker
Copy link
Member

Thanks for the updates, @martinholmer , merging.

@jdebacker jdebacker merged commit c90448e into PSLmodels:master Mar 17, 2024
9 checks passed
@martinholmer martinholmer deleted the revise-ppp branch March 27, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants