Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline table to output file generated by the tc --sqldb command #2714

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

martinholmer
Copy link
Collaborator

In prior versions of the Tax-Calculator CLI tool, tc, the --sqldb option created an SQLite3 database that contained variables for the specified reform, but not variables for the baseline. This made it more difficult for users to conduct analysis of policy reforms using SQL scripts.

This pull request enhances the tc tool so that the --sqldb option generates an SQLite3 database that contains two tables (each containing the same set of specified variables), one for the baseline and one for the reform.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f850d81) 98.54% compared to head (d806ac3) 98.54%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2714   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        2608     2616    +8     
=======================================
+ Hits         2570     2578    +8     
  Misses         38       38           
Flag Coverage Δ
unittests 98.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
taxcalc/taxcalcio.py 100.00% <100.00%> (ø)

@jdebacker
Copy link
Member

@martinholmer Thanks for making this change.

Can you write a unit test that covers the taxcalcio.analyze function with the new outputs? With that, I think this PR will be ready to merge.

@martinholmer
Copy link
Collaborator Author

@jdebacker, Why am I now getting the following error?
What is the failing test meant to do: Test reading JSON assumption file using URL.

Screenshot 2024-02-06 at 1 25 19 PM

@martinholmer martinholmer reopened this Feb 6, 2024
@martinholmer
Copy link
Collaborator Author

@jdebacker, Can you merge #2714?
This PR did pass all the tests on ubuntu,3.9.

@jdebacker
Copy link
Member

Thanks @martinholmer. Merging.

@jdebacker jdebacker merged commit 51b0941 into PSLmodels:master Feb 6, 2024
5 of 20 checks passed
@martinholmer martinholmer deleted the tc-sqldb branch February 6, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants