Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAXSIM-35 Validation, "b" files #2705

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Conversation

jdebacker
Copy link
Member

@jdebacker jdebacker commented Nov 14, 2023

This PR works through the validation of the "b" files in the TAXSIM-35 validation suite.

To validate:

  • 2017
  • 2018
  • 2019
  • 2020
  • 2021

@bodiyang
Copy link
Contributor

bodiyang commented Nov 29, 2023

Payroll tax is good to pass, with details can be found in the payroll tax validation issue.

  • Taxsim35 is going through update, with FICA tax calculation method change.

  • The updated version of Taxsim and Tax-Calculator show no difference in FICA tax calculation result

  • The updated version of Taxsim does not provide SECA tax result, so we cannot do validation of SECA tax. However, I've tried to compare the SECA tax result from Tax-Calculator and my manual calculation, of many randomly selected records in different sets among different years. The results are correct.

So payrolltax (FICA+SECA) validation should be considered to pass

@bodiyang
Copy link
Contributor

bodiyang commented Nov 29, 2023

AGI c00100 validation:

I have manually calculated the AGE c00100 variable in "b", "c" sets for all years.

Tax-Calculator's result should be correct.

Some detailed analysis:

c00100 = ymod1 + c02500 - c02900 + taxable_ubi

Under Taxsim's variable name:
ymod1 = pwages + swages + psemp + ssemp + dividends + intrec + otherprop + nonprop + pensions + pui +sui + scorp + pbusinc + sbusinc + MAX(-3000, stcg + ltcg)

c02500, social security benefit in AGI, is calculated based on gssi variable from Taxsim. I have manually calculated this item following Social Security Benefits Worksheet -- line 20a and 20b, in 1040 instructions. The result of c02500 matches with Tax-Calculator's result

taxable_ubi is Zero for all years in the validation sets, so there is no problem with this item

c02900, total of all "above the line" income adjustments to get AGI: This variable is consisted of many items, as in form 1040 Sch 1 . However, the only variable which is not zero, in this validation, is Deductible part of self-employment tax e03260. And since e03260 = 0.5 * setax , we only need to conduct the validation of self-employment tax.
From my last comment, SECA tax validation issue should not be concerned

So the c00100 AGI in Tax-Calculator should be correct. ~ difference of c00100 in Taxsim is likely come from the SECA tax calculation process (as mentioned before, Taxsim's payroll tax calculation is under the work of update)

@bodiyang
Copy link
Contributor

c11070 Child Tax Credit for 2021 validation:

For year 2021, Child tax credit is categorized as nonrefundable child tax credit. So c11070 as the refunded Child tax credit is count as zero in Tax-Calculator. Taxsim35 calculates the amount of Child tax credit (it does not differentiate refundable vs nonrefundable credit)
This issue is the same as and has been documented in the "a" set validation PR

@jdebacker
Copy link
Member Author

@bodiyang Thanks for reviewing the differences.

Re c11070: The issue of refundability or not (and where counted) should be handled for 2021 via this fix to the taxcalc output. That's where there's no difference in this variable in the "a" set validation for 2021. So I believe the 6 records with differences in the 2021 "b" file are due to something else.

Re c00100, I don't think we can be confident in the overall AGI until we have the intermediate variables (such a c11070 taken care of). The diffs in AGI are pointing to underlying difference in the calculation of the components, so differences here not just reflecting the direct computation of the AGI you noted above.

Re the payroll taxes -- thanks for noting these known differences. Due to this, let's focus n getting the AGI/iitax difference to zero (or explaining any diffs) and not worry about payroll taxes.

@bodiyang
Copy link
Contributor

bodiyang commented Dec 1, 2023

@jdebacker

For c00100: I've already compared the intermediate variables, which are involved in c00100 calculation

note: c11070 is involved in the iitax calculation, but not c00100 AGI calculation

As documented in the previous comment:
c00100 = ymod1 + c02500 - c02900 + taxable_ubi
intermediate variables here are ymod1, c02500, c02900 and taxable_ubi
We cannot get the value of these from Taxsim, so the way of validation is to compare the value of these intermediate variables from Tax-Calculator with manual calculation from tax forms.

ymod1 = pwages + swages + psemp + ssemp + dividends + intrec + otherprop + nonprop + pensions + pui +sui + scorp + pbusinc + sbusinc + MAX(-3000, stcg + ltcg)
ymod1 is calculated directly from the input variable, and the value of this is correct.

other intermediate variables, c02500, c02900, taxable_ubi can be found at the details here

@bodiyang
Copy link
Contributor

bodiyang commented Dec 15, 2023

amt_liability is correct in Tax-Calculator

Taxsim zero out all of the amt_liability result, so should not be considered in the validation.
I've conduct manual calculation (in both 'b' & 'c' sets, from different years) following tax form 6251 and the manual calculation results all match with the Tax-Calculator's results.

@feenberg
Copy link
Contributor

feenberg commented Dec 16, 2023 via email

@bodiyang
Copy link
Contributor

bodiyang commented Dec 18, 2023

Can you explain what you mean by "taxsim zero out all of the amt_liability result"? Are you referring to a taxsim output variable? What name? I am on vacation and will return to Cambridge on December 21, and can fix problems then. Dan 617-682-6204

On Fri, 15 Dec 2023, Bodi Yang wrote: amt_liability is correct in Tax-Calculator Taxsim zero out all of the amt_liability result, so should not be considered in the validation. I've conduct manual calculation (of different records from different years) following tax form 6251 and the manual calculation results all match with the Tax-Calculator's results. -- Reply to this email directly or view it on GitHub: #2705 (comment) You are receiving this because you are subscribed to this thread. Message ID: @.***>

Taxsim's AMT calculation output ('27.AMT' in 'Federal tax calculation') is always zero, for all records which should have AMT.

As an example:

taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl

This record should have $20401 AMT liability, but Taxsim is showing zero for the AMT output.

Bodi

@bodiyang
Copy link
Contributor

bodiyang commented Dec 19, 2023

non_refundable_child_odep_credit is correct in Tax-Calculator.

The result of my manual calculation match with the Tax-Calculator's result.
To be noticed both Taxcalc and Taxsim do not consider the $1,000 rounding rule for the year 2021, as documented in issue

example record in c21:
taxsimid 222 year 2021 state mstat 2 page 75 sage 74 depx 3 dep13 3 dep17 3 dep18 3 pwages 14000 swages 20000 psemp 278 ssemp 281 dividends 18000 intrec 5000 stcg 0 ltcg -2000 otherprop 3000 nonprop 26000 pensions 16000 gssi 16000 pui 10000 sui 7000 transfers 0 rentpaid 0 proptax 6000 otheritem 10000 childcare 4000 mortgage 39000 scorp 165000 pbusinc 121000 pprofinc 0 sbusinc 114000 sprofinc

  • The non_refundable_child_odep_credit should be $250, by my manual calculation following form 1040 schdule 8812.
  • Tax-Calculator result is $274.14; Taxsim result is $3.17

So Tax-Calculator does slight off by the manual calculation, this is because of the $1,000 rounding rule mentioned in the issue above; I don't see the reason why Taxsim is off

manual calculation is in IMG_5185.HEIC.zip

The above is an example record. I have gone through records in both 'b' & 'c' set and Tax-Calculator should be correct.

@bodiyang
Copy link
Contributor

@jdebacker I'm including both 'b' and 'c' sets validation in this PR, because they are showing similar differences.

@feenberg
Copy link
Contributor

feenberg commented Dec 25, 2023 via email

@bodiyang
Copy link
Contributor

I am concerned that apparently this taxpayer with mstat=1 has both pui and sui non-zero. Taxsim checks for that, so perhaps sui is intended to be zero? I'll continue working under that assumption. It would help if sent all the results for this taxpayer, and possibly your calculation. Daniel Feenberg 617-682-6204

On 12/18/23, Bodi Yang @.> wrote: > Can you explain what you mean by "taxsim zero out all of the amt_liability > result"? Are you referring to a taxsim output variable? What name? I am on > vacation and will return to Cambridge on December 21, and can fix problems > then. Dan 617-682-6204 > > On Fri, 15 Dec 2023, Bodi Yang wrote: amt_liability is correct in > Tax-Calculator Taxsim zero out all of the amt_liability result, so should > not be considered in the validation. I've conduct manual calculation (of > different records from different years) following tax form 6251 and the > manual calculation results all match with the Tax-Calculator's results. -- > Reply to this email directly or view it on GitHub: [#2705 > (comment)](#2705 (comment)) > You are receiving this because you are subscribed to this thread. Message > ID: @.> Taxsim's AMT calculation output ('27.AMT' in 'Federal tax calculation') is always zero, for all records which should have AMT. As an example: taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl This record should have $20401 AMT liability, but Taxsim is showing zero for the AMT output. -- Reply to this email directly or view it on GitHub: #2705 (comment) You are receiving this because you commented. Message ID: @.***>

The result I got from taxsim of this record is: income tax $95709.64. payroll tax $27665.4. AGI $ 519936.6

My manual calculation can be found in the attached picture zip file in my previous comment

Best,
Bodi

@feenberg
Copy link
Contributor

feenberg commented Dec 25, 2023 via email

@bodiyang
Copy link
Contributor

On Mon, 25 Dec 2023, Bodi Yang wrote: My manual calculation can be found in [the attached picture zip file in my previous comment](#2705 (comment))
At that page I see highlighted a link to a for 8812 that is not relevant. Daniel Feenberg 617-682-6204

Best, Bodi -- Reply to this email directly or view it on GitHub: #2705 (comment) You are receiving this because you commented. Message ID: @.***>

Oh I see, we probably end up talking about different issues in this PR. Sorry about the confusion. So there are two issues so far ~

  1. I posted the issue of AMT in this comment

record:
taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl

This record should have $20401 AMT liability, but Taxsim is showing zero for the AMT output.

Taxsim output: income tax $ 213264.5. payroll tax: $27343.59. AGI: $762930.7

  1. And another issue of child tax credit in another comment here

example record:
taxsimid 222 year 2021 state mstat 2 page 75 sage 74 depx 3 dep13 3 dep17 3 dep18 3 pwages 14000 swages 20000 psemp 278 ssemp 281 dividends 18000 intrec 5000 stcg 0 ltcg -2000 otherprop 3000 nonprop 26000 pensions 16000 gssi 16000 pui 10000 sui 7000 transfers 0 rentpaid 0 proptax 6000 otheritem 10000 childcare 4000 mortgage 39000 scorp 165000 pbusinc 121000 pprofinc 0 sbusinc 114000 sprofinc

The non_refundable_child_odep_credit should be $250, by my manual calculation following form 1040 schdule 8812.
Tax-Calculator result is $274.14; Taxsim result is $3.17

The result I got from taxsim of this record is: income tax $95709.64. payroll tax $27665.4. AGI $ 519936.6

@bodiyang
Copy link
Contributor

On Mon, 25 Dec 2023, Bodi Yang wrote: My manual calculation can be found in [the attached picture zip file in my previous comment](#2705 (comment))
At that page I see highlighted a link to a for 8812 that is not relevant. Daniel Feenberg 617-682-6204

Best, Bodi -- Reply to this email directly or view it on GitHub: #2705 (comment) You are receiving this because you commented. Message ID: @.***>

Oh I see, we probably end up talking about different issues in this PR. Sorry about the confusion. So there are two issues so far ~

  1. I posted the issue of AMT in this comment

record: taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl

This record should have $20401 AMT liability, but Taxsim is showing zero for the AMT output.

Taxsim output: income tax $ 213264.5. payroll tax: $27343.59. AGI: $762930.7

  1. And another issue of child tax credit in another comment here

example record: taxsimid 222 year 2021 state mstat 2 page 75 sage 74 depx 3 dep13 3 dep17 3 dep18 3 pwages 14000 swages 20000 psemp 278 ssemp 281 dividends 18000 intrec 5000 stcg 0 ltcg -2000 otherprop 3000 nonprop 26000 pensions 16000 gssi 16000 pui 10000 sui 7000 transfers 0 rentpaid 0 proptax 6000 otheritem 10000 childcare 4000 mortgage 39000 scorp 165000 pbusinc 121000 pprofinc 0 sbusinc 114000 sprofinc

The non_refundable_child_odep_credit should be $250, by my manual calculation following form 1040 schdule 8812. Tax-Calculator result is $274.14; Taxsim result is $3.17

The result I got from taxsim of this record is: income tax $95709.64. payroll tax $27665.4. AGI $ 519936.6

I may send my manual calculation of the AMT issue later. I'm traveling and left my manual calculation draft in office. Will get back next week.

@feenberg
Copy link
Contributor

feenberg commented Dec 26, 2023 via email

@feenberg
Copy link
Contributor

feenberg commented Dec 26, 2023 via email

@bodiyang
Copy link
Contributor

bodiyang commented Jan 2, 2024

Oh, I see, there isn't a manual calculation for the AMT yet. I missed that. I'll put off working on this then. Sorry Daniel Feenberg 617-682-6204

On Mon, 25 Dec 2023, Bodi Yang wrote: >> On Mon, 25 Dec 2023, Bodi Yang wrote: My manual calculation can be found in [the attached picture zip file in my previous comment]([#2705 (comment)](#2705 (comment))) >> At that page I see highlighted a link to a for 8812 that is not relevant. Daniel Feenberg 617-682-6204 >> ? >> Best, Bodi -- Reply to this email directly or view it on GitHub: [#2705 (comment)](#2705 (comment)) You are receiving this because you commented. Message ID: @.> > > Oh I see, we probably end up talking about different issues in this PR. Sorry about the confusion. So there are two issues so far ~ > > 1. I posted the issue of AMT [in this comment](#2705 (comment)) > > record: taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl > > This record should have $20401 AMT liability, but Taxsim is showing zero for the AMT output. > > Taxsim output: income tax $ 213264.5. payroll tax: $27343.59. AGI: $762930.7 > > 2. And another issue of child tax credit [ in another comment here](#2705 (comment)) > > example record: taxsimid 222 year 2021 state mstat 2 page 75 sage 74 depx 3 dep13 3 dep17 3 dep18 3 pwages 14000 swages 20000 psemp 278 ssemp 281 dividends 18000 intrec 5000 stcg 0 ltcg -2000 otherprop 3000 nonprop 26000 pensions 16000 gssi 16000 pui 10000 sui 7000 transfers 0 rentpaid 0 proptax 6000 otheritem 10000 childcare 4000 mortgage 39000 scorp 165000 pbusinc 121000 pprofinc 0 sbusinc 114000 sprofinc > > The non_refundable_child_odep_credit should be $250, by my manual calculation following form 1040 schdule 8812. Tax-Calculator result is $274.14; Taxsim result is $3.17 > > The result I got from taxsim of this record is: income tax $95709.64. payroll tax $27665.4. AGI $ 519936.6 I may send my manual calculation of the AMT issue later. I'm traveling and left my manual calculation draft in office. Will get back next week. -- Reply to this email directly or view it on GitHub: #2705 (comment) You are receiving this because you commented. Message ID: @.>

Hi Daniel, I've attached the manual calculation of the AMT issue record in this file: AMT record.zip
The manual calculation follows form 6251 of the year 2021

note: line 4 of the form, Alternative minimum taxable income $762940; and line 10 of the form, Form 1040 or 1040-SR line 16 ... $183930 are intermediate variables read from output of Tax-Calculator
(These two intermediate variables' result from Taxsim are: AMT taxable income $700942; line 16 of form 1040 is $214387)

record input:
taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl

This record should have $20401 AMT liability, but Taxsim is showing zero for the AMT output.

Taxsim output: income tax $ 213264.5. payroll tax: $27343.59. AGI: $762930.7

@feenberg
Copy link
Contributor

feenberg commented Jan 4, 2024 via email

@bodiyang
Copy link
Contributor

bodiyang commented Jan 5, 2024

Can you send the 1040, Qualified Dividens and Capital Gain Tax worksheet and Schedule D itself also? I need to be able to put the taxpayer into TaxAct and see what it calculates and I am having trouble getting TaxAct to generate the numbers for line13, 20 and 27 of form 6251. Thanks Daniel Feenberg +1 617-682-6204

On 1/2/24, Bodi Yang @.> wrote: > Oh, I see, there isn't a manual calculation for the AMT yet. I missed > that. I'll put off working on this then. Sorry Daniel Feenberg > 617-682-6204 > > On Mon, 25 Dec 2023, Bodi Yang wrote: >> On Mon, 25 Dec 2023, Bodi Yang > wrote: My manual calculation can be found in [the attached picture zip > file in my previous comment]([#2705 (comment)]([#2705 > (comment)](#2705 (comment)))) > >> At that page I see highlighted a link to a for 8812 that is not > relevant. Daniel Feenberg 617-682-6204 >> ? >> Best, Bodi -- Reply to > this email directly or view it on GitHub: [#2705 (comment)]([#2705 > (comment)](#2705 (comment))) > You are receiving this because you commented. Message ID: _@_.> > > > Oh I see, we probably end up talking about different issues in this PR. > Sorry about the confusion. So there are two issues so far ~ > > 1. I > posted the issue of AMT [in this comment]([#2705 > (comment)](#2705 (comment))) > > > record: taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 > dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec > 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi > 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare > mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl > > > This record should have $20401 AMT liability, but Taxsim is showing zero > for the AMT output. > > Taxsim output: income tax $ 213264.5. payroll tax: > $27343.59. AGI: $762930.7 > > 2. And another issue of child tax credit > [ in another comment here]([#2705 > (comment)](#2705 (comment))) > > > example record: taxsimid 222 year 2021 state mstat 2 page 75 sage 74 > depx 3 dep13 3 dep17 3 dep18 3 pwages 14000 swages 20000 psemp 278 ssemp > 281 dividends 18000 intrec 5000 stcg 0 ltcg -2000 otherprop 3000 nonprop > 26000 pensions 16000 gssi 16000 pui 10000 sui 7000 transfers 0 rentpaid 0 > proptax 6000 otheritem 10000 childcare 4000 mortgage 39000 scorp 165000 > pbusinc 121000 pprofinc 0 sbusinc 114000 sprofinc > > The > non_refundable_child_odep_credit should be $250, by my manual calculation > following form 1040 schdule 8812. Tax-Calculator result is $274.14; Taxsim > result is $3.17 > > The result I got from taxsim of this record is: income > tax $95709.64. payroll tax $27665.4. AGI $ 519936.6 I may send my manual > calculation of the AMT issue later. I'm traveling and left my manual > calculation draft in office. Will get back next week. -- Reply to this > email directly or view it on GitHub: [#2705 > (comment)](#2705 (comment)) > You are receiving this because you commented. Message ID: @.> Hi Daniel, I've attached the manual calculation of the AMT issue record in this file: AMT record.zip The manual calculation follows form 6251 of the year 2021 note: line 4 of the form, Alternative minimum taxable income $762940; and line 10 of the form, Form 1040 or 1040-SR line 16 ... $183930 are intermediate variables read from output of Tax-Calculator (These two intermediate variables' result from Taxsim are: AMT taxable income $700942; line 16 of form 1040 is $214387) record input: taxsimid year 2021 state mstat 1 page 77 sage depx 5 dep13 0 dep17 0 dep18 0 pwages 2000 swages psemp 147 ssemp dividends 17000 intrec 7000 stcg 7000 ltcg 1000 otherprop 19000 nonprop 13000 pensions 24000 gssi 1000 pui 6000 sui 6000 transfers rentpaid proptax otheritem childcare mortgage scorp 350000 pbusinc 323000 pprofinc sbusinc sprofinc idtl This record should have $20401 AMT liability, but Taxsim is showing zero for the AMT output. Taxsim output: income tax $ 213264.5. payroll tax: $27343.59. AGI: $762930.7 -- Reply to this email directly or view it on GitHub: #2705 (comment) You are receiving this because you commented. Message ID: @.**>

I've attached the Qualified Dividends and Capital Gain Tax Worksheet and form 1040 Sch D ~ I only completed the lines which is related

When filling Form 6251
line 13 of Form 6251 = line 4 of Qualified Dividends and Capital Gain Tax Worksheet = 18000
line 20 of Form 6251 = line 5 of Qualified Dividends and Capital Gain Tax Worksheet = 589811
line 27 of Form 6251 = line 5 of Qualified Dividends and Capital Gain Tax Worksheet = 589811

Note: line 1 of the Qualified Dividends and Capital Gain Tax Worksheet is the taxable income Form 1040 line 15, which is read from the Tax-Calculator output $607811 (taxable income from Taxsim35 is $680442)

@feenberg
Copy link
Contributor

feenberg commented Jan 5, 2024 via email

@jdebacker
Copy link
Member Author

@bodiyang Can you look at the Differences_Explained.md file and let me know if I've gotten the description of the differences in the "b" set correct? Thanks!

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (e2f14f3) to head (7c9e432).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2705   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        2616     2616           
=======================================
  Hits         2578     2578           
  Misses         38       38           
Flag Coverage Δ
unittests 98.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bodiyang
Copy link
Contributor

@bodiyang Can you look at the Differences_Explained.md file and let me know if I've gotten the description of the differences in the "b" set correct? Thanks!

The description looks good to me. Just on point, it's better to clarify TAXMSIM as TAXSIM-35 in the 'b' file section (because the updated testing version of TAXSIM have some calculation differences from TAXSIM-35).

@feenberg
Copy link
Contributor

feenberg commented Jan 17, 2024 via email

@jdebacker jdebacker marked this pull request as ready for review January 29, 2024 18:26
@jdebacker jdebacker merged commit 39f7502 into PSLmodels:master Feb 29, 2024
9 checks passed
@jdebacker jdebacker deleted the taxsim_b_set branch February 29, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants