consider odc in iitax calculation #2704
Conversation
update from forked repo
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 14 14
Lines 2609 2609
=======================================
Hits 2571 2571
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@jdebacker all tests pass locally; online test experiencing the codecov issue again. Can you have a rerun see if we can pass? |
taxcalc/calcfunctions.py
Outdated
| @@ -3309,12 +3309,12 @@ def IITAX(c59660, c11070, c10960, personal_refundable_credit, ctc_new, rptc, | |||
| Sum of iitax and payrolltax and lumpsum_tax | |||
| """ | |||
| eitc = c59660 | |||
| if CTC_refundable: | |||
| ctc_refund = c07220 | |||
| if CTC_refundable and ODC_refundable: | |||
There was a problem hiding this comment.
@bodiyang I would have a separate set of if/else cases for ODC_refundable, rather than combine as here. What you've done misses the case of CTC_refundable = False and ODC_refundable=True.
taxcalc/calcfunctions.py
Outdated
| refund = (eitc + c11070 + c10960 + CDCC_refund + recovery_rebate_credit + | ||
| personal_refundable_credit + ctc_new + rptc + ctc_refund) | ||
| personal_refundable_credit + ctc_new + rptc + ctc_odc_refund) |
There was a problem hiding this comment.
If you separate as suggested above, you will have ... + ctc_refund + odc_refund)
|
@bodiyang Thanks for this PR! Nice addition of a new parameter to handle 2021 law. I have some suggestions on how you handle the cases in |
|
@jdebacker Thanks for the review. All tests pass locally and on git action. Please check if the PR is ready to merge |
|
Great - thank you @bodiyang! Merging. |
This PR address the issue that other dependent credit should be taken into consideration in the iitax calculation.
For the year 2021, child tax credit and other dependent credit are categorized as refundable tax credit. iitax should reflect this change for the year 2021 (note: only for the year 2021, all other years ctc and odc are nonrefundable).