Fix value of CTC_new_c_under6_bonus #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdebacker
changed the title
|
@MattHJensen All tests pass for me locally. This PR is ready for your review. |
Codecov Report
@@ Coverage Diff @@
## master #2609 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 14 14
Lines 2611 2611
=======================================
Hits 2571 2571
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This looks good to me. Thanks to @JackLandry for helping w/ identification and @jdebacker for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the value for the
CTC_new_c_under6_bonusin thepolicy_current_law.jsonfile. The value is currently set at $1,000 in 2021, but @JackLandry correctly points out that the value should be $600 (see Issue #2608).With this correction, I update the
test_reforms.py::test_round_trip_tcja_reformto test years 2019-2022, rather than just 2020, which would have caught this error.