-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code changes to model ARPA #2573
Conversation
taxcalc/policy_current_law.json
Outdated
"UI_em": { | ||
"title": "Unemployment Insurance exemption amount", | ||
"description": "The amount of Unemployment Insurance benefits excluded from taxable income.", | ||
"notes": "Enacter retroactively for 2020 by the American Rescue Plan Act of 2021", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enacter -> Enacted
@codykallen, this is looking great to me upon initial review. I'll leave it open for others to take a look until this (Sunday) evening when I hope to merge and then release first thing tomorrow morning. |
Per the discussion with @kpomerleau in issue #2571, the newest commit changes how we calculate the number of 17-year-olds eligible for the CTC under ARPA. The previous logic raised the number of CTC-eligible children by 27.3 million in 2021, whereas the new logic raises it by 1.9 million, a much more reasonable result. |
It looks like the only test failing in this PR is in the Jupyter Book documentation tests. The error message looks like it has to do with Python 3.9. It says:
The The testing in these
|
@codykallen, thanks again for this big contribution. @jdebacker, @kpomerleau, and @rickecon, thanks for your help with the review process. I am going to merge this now since the failing test should pass on master thanks to #2575. If it doesn't, we'll make sure it is passing before releasing. |
Sorry, @codykallen, I saw your latest commit right after merging, and I didn't let the tests run. They are running on master now. https://github.com/PSLmodels/Tax-Calculator/runs/2112290774 |
Tests passed on master. |
This implements the code changes necessary to model the tax changes in the American Rescue Plan Act of 2021, as described in issue #2571. This adds the following policy parameters and their associated logic:
RRC_c
,RRC_ps
,RRC_pe
: Parameters to implement the Recovery Rebate Credit (i.e. $1,400 payments)UI_em
,UI_thd
: Parameters to implement the exclusion of UI benefits from taxable income, up to $10,200 for those with AGI below $150,000.CDCC_ps2
,CDCC_refundable
: Parameters to implement changes to the CDCC.CTC_include17
,CTC_refundable
: Parameters to implement changes to the CTC.In addition to these new policy parameters and the logic to implement them, I made the following further changes:
CDCC_frt
andCDCC_prt
, to replace their hardcoded values in theF2441
logic.ChildDepTaxCredit
function to make it easier to implement the CTC refundability. This refactoring removed some unnecessary code but does not change the underlying logic, so the results do not change.pycodestyle
.The next steps for this PR are to add the reform file (in progress), and to add tests to provide coverage for the new code.
@MattHJensen, @martinholmer, @grantseiter, @MaxGhenis, @Thirdhuman, @ernietedeschi, @kpomerleau