Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3.0.0 #2474

Merged
merged 7 commits into from
Aug 24, 2020
Merged

Prepare 3.0.0 #2474

merged 7 commits into from
Aug 24, 2020

Conversation

MattHJensen
Copy link
Contributor

This prepares 3.0.0.

Pending resolution of #2450.

@Peter-Metz, could you look this over if you have an oportunity?

@MattHJensen
Copy link
Contributor Author

Thanks to contributions from @Peter-Metz, @hdoupe, @MaxGhenis, @jdebacker, @chusloj, @andersonfrailey, many of which but not all are recognized in docs/about/releases.md!

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #2474 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2474   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          13       13           
  Lines        2582     2582           
=======================================
  Hits         2580     2580           
  Misses          2        2           
Impacted Files Coverage Δ
taxcalc/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26fea1...363d4c8. Read the comment docs.

Copy link
Contributor

@Peter-Metz Peter-Metz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattHJensen this is looking good! Two minor comments in addition to the notes I left:

docs/about/releases.md Outdated Show resolved Hide resolved
docs/about/releases.md Outdated Show resolved Hide resolved
docs/about/releases.md Outdated Show resolved Hide resolved
docs/about/releases.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@MattHJensen
Copy link
Contributor Author

I'll look at this JB failure later today. May have something to do with #2476 given that latest commit to this PR was rather innocuous.

@hdoupe
Copy link
Collaborator

hdoupe commented Aug 24, 2020

@MattHJensen this looks like a flaky failure due to the anaconda service being unavailable temporarily:

Screenshot from 2020-08-24 08-06-41

I just restarted the tests.

@MattHJensen MattHJensen changed the title [WIP] Prepare 3.0.0 Prepare 3.0.0 Aug 24, 2020
@MattHJensen MattHJensen merged commit ba7c251 into PSLmodels:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants