-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 3.0.0 #2474
Prepare 3.0.0 #2474
Conversation
Thanks to contributions from @Peter-Metz, @hdoupe, @MaxGhenis, @jdebacker, @chusloj, @andersonfrailey, many of which but not all are recognized in docs/about/releases.md! |
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 13 13
Lines 2582 2582
=======================================
Hits 2580 2580
Misses 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MattHJensen this is looking good! Two minor comments in addition to the notes I left:
- Can drop the reference to
CHANGES.md
from the first line ofRELEASING.md
- Will the parameter docs build when 3.0 is released? I'm not sure of the resolution of Add action for setting up parameters docs #2450
I'll look at this JB failure later today. May have something to do with #2476 given that latest commit to this PR was rather innocuous. |
@MattHJensen this looks like a flaky failure due to the anaconda service being unavailable temporarily: I just restarted the tests. |
This prepares 3.0.0.
Pending resolution of #2450.
@Peter-Metz, could you look this over if you have an oportunity?