Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepares release 2.9.0 #2405

Merged
merged 7 commits into from
Mar 18, 2020
Merged

Prepares release 2.9.0 #2405

merged 7 commits into from
Mar 18, 2020

Conversation

MattHJensen
Copy link
Contributor

@Peter-Metz, could you look over this?

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2405 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2405   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         2751      2751           
=========================================
  Hits          2751      2751           
Impacted Files Coverage Δ
taxcalc/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf5991...4d5e06b. Read the comment docs.

@@ -1,6 +1,6 @@
<!DOCTYPE html>
<!-- *** NEVER EDIT THIS FILE BY HAND *** -->
<!-- *** INSTEAD EDIT docs/tc_history.htmx *** -->
<!-- *** INSTEAD EDIT /Users/matthewjensen/Projects/Tax-Calculator/docs/tc_history.htmx FILE *** -->
Copy link
Contributor

@Peter-Metz Peter-Metz Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to revert file path @MattHJensen

@@ -1,6 +1,6 @@
<!DOCTYPE html>
<!-- *** NEVER EDIT THIS FILE BY HAND *** -->
<!-- *** INSTEAD EDIT docs/tc_license.htmx *** -->
<!-- *** INSTEAD EDIT /Users/matthewjensen/Projects/Tax-Calculator/docs/tc_license.htmx FILE *** -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here @MattHJensen

@@ -1,6 +1,6 @@
<!DOCTYPE html>
<!-- *** NEVER EDIT THIS FILE BY HAND *** -->
<!-- *** INSTEAD EDIT docs/tc_overview.htmx *** -->
<!-- *** INSTEAD EDIT /Users/matthewjensen/Projects/Tax-Calculator/docs/tc_overview.htmx FILE *** -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@@ -1,6 +1,6 @@
<!DOCTYPE html>
<!-- *** NEVER EDIT THIS FILE BY HAND *** -->
<!-- *** INSTEAD EDIT docs/tc_roadmap.htmx *** -->
<!-- *** INSTEAD EDIT /Users/matthewjensen/Projects/Tax-Calculator/docs/tc_roadmap.htmx FILE *** -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@@ -1,6 +1,6 @@
<!DOCTYPE html>
<!-- *** NEVER EDIT THIS FILE BY HAND *** -->
<!-- *** INSTEAD EDIT docs/tc_starting.htmx *** -->
<!-- *** INSTEAD EDIT /Users/matthewjensen/Projects/Tax-Calculator/docs/tc_starting.htmx FILE *** -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@Peter-Metz
Copy link
Contributor

@MattHJensen I think a few file paths got changed that shouldn't have, but everything else looks good.

@MattHJensen
Copy link
Contributor Author

Thanks @Peter-Metz. I will merge this as soon as the tests complete and then proceed with the release.

@MattHJensen MattHJensen merged commit 0e6dee1 into PSLmodels:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants