Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tc CLI docs about when extrapolation takes place #2394

Merged
merged 6 commits into from
Dec 13, 2019

Conversation

MattHJensen
Copy link
Contributor

@MattHJensen MattHJensen commented Dec 13, 2019

Resolves #2384 (cc @donboyd5).

  • adds a paragraph to the uguide about how your data filename influences extrapolation.
  • increases the specificity of the reform documentation .text file so that it does not tell the user that default growth assumptions have been applied even when no extrapolation took place.
  • adds a new message on startup when data are not extrapolated to accompany the message offered when data are extrapolated.
    image

This PR also updates the results -- minor changes -- for reform 56, which repeals the TCJA CPI adjustment. I am assuming that these changes are a result of #2388 and were just overlooked in testing as they raise an error and not a test failure. (cc @MaxGhenis).

@MattHJensen MattHJensen changed the title Improve tc documentation about when extrapolation takes place Improve tc CLI docs about when extrapolation takes place Dec 13, 2019
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #2394 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2394   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          13      13           
  Lines        2749    2751    +2     
======================================
+ Hits         2749    2751    +2
Impacted Files Coverage Δ
taxcalc/calculator.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4694417...6755e08. Read the comment docs.

@MattHJensen MattHJensen merged commit 5811aa1 into PSLmodels:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeking quick bit of advice interpreting what tc CLI does
1 participant