Consolidate all the private validate logic in the Parameters class #2281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consolidates all the parameter
_validate_names_types
and_validate_values
logic in the Parameters class. This change reduces code duplication and makes the abstract Parameters class a better candidate for using to build policy parameter and/or assumption parameter classes in other models that are already importing the taxcalc package. This pull request also removes from the Parameters class code all hardcoded names of wage-indexed parameters. And it moves the code that reads the DEFAULTS JSON file to create a_vals
dictionary into the Parameters class constructor, where it should have been in the original design of the Parameters class.