Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen testing of 2017_law.json and TCJA.json reform files #2217

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Strengthen testing of 2017_law.json and TCJA.json reform files #2217

merged 4 commits into from
Feb 5, 2019

Conversation

martinholmer
Copy link
Collaborator

This pull requests adds two new tests to the test_reforms.py file. The strengthened testing and the recent change in Policy.LAST_KNOWN_YEAR from 2017 to 2018 (in #2212) revealed the need for some changes in the 2017_law.json and TCJA.json reform files and the need for one small change in the logic that implements a reform containing nonzero values of the _cpi_offset parameter.

cc @MattHJensen @codykallen

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #2217 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2217   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2957    2976   +19     
======================================
+ Hits         2957    2976   +19
Impacted Files Coverage Δ
taxcalc/parameters.py 100% <100%> (ø) ⬆️
taxcalc/policy.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a7947...c97d49f. Read the comment docs.

@martinholmer martinholmer added ready and removed ready labels Feb 4, 2019
@martinholmer martinholmer merged commit 3f9f024 into PSLmodels:master Feb 5, 2019
@martinholmer martinholmer deleted the fix-rtr-test branch February 5, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant