Fix bottom decile sub-categories in distribution and difference tables #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholmer
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2192 +/- ##
======================================
Coverage 100% 100%
======================================
Files 12 12
Lines 2944 2948 +4
======================================
+ Hits 2944 2948 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an earlier refactoring of the (distribution and difference) table-creation logic, the negative/zero/positive sub-categories of the
0-10decile were lost; the whole bottom decile was incorrectly shown on the0-10ptable row. This pull request restores the correct sub-category logic. The bug fixed in this pull request was introduced in commit a9108e5, which was part of PR #1972, and first appeared in the 0.19.0 release.