Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Tax-Calculator code to being compatible with Python 3.6 only #2058

Merged
merged 19 commits into from
Sep 11, 2018
Merged

Switch Tax-Calculator code to being compatible with Python 3.6 only #2058

merged 19 commits into from
Sep 11, 2018

Conversation

martinholmer
Copy link
Collaborator

The next Tax-Calculator release will be 0.21.0 and the release notes for that version will include an API Change that says it is compatible with only Python 3.6.

Incompatibilities in the pandas library for Python 2.7 and Python 3.6 make it extremely difficult to make Tax-Calculator code and Cookbook recipes be compatible with both Python 2.7 and Python 3.6. We've been warning for many months that support for Python 2.7 was ending soon and that Tax-Calculator users should upgrade to Python 3.6 as soon as possible. The 0.20.3 release, which is compatible with Python 2.7, will remain available to users who have not upgraded to Python 3.6.

@codecov-io
Copy link

codecov-io commented Sep 8, 2018

Codecov Report

Merging #2058 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2058      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files          16       16              
  Lines        3530     3515      -15     
==========================================
- Hits         3529     3514      -15     
  Misses          1        1
Impacted Files Coverage Δ
taxcalc/behavior.py 100% <ø> (ø) ⬆️
taxcalc/growmodel.py 98.18% <ø> (-0.04%) ⬇️
taxcalc/taxcalcio.py 100% <100%> (ø) ⬆️
taxcalc/calculate.py 100% <100%> (ø) ⬆️
taxcalc/decorators.py 100% <100%> (ø) ⬆️
taxcalc/records.py 100% <100%> (ø) ⬆️
taxcalc/policy.py 100% <100%> (ø) ⬆️
taxcalc/utils.py 100% <100%> (ø) ⬆️
taxcalc/growfactors.py 100% <100%> (ø) ⬆️
taxcalc/parameters.py 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3729a7...ba55a28. Read the comment docs.

@martinholmer martinholmer changed the title Switch Tax-Calculator to being compatible with Python 3.6 only Switch Tax-Calculator code to being compatible with Python 3.6 only Sep 8, 2018
@martinholmer martinholmer merged commit 8802bfd into PSLmodels:master Sep 11, 2018
@martinholmer martinholmer deleted the develop-with-python36 branch September 11, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants