Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new puf.csv file containing new pencon_? variables; update some logic and test results #2056

Merged
merged 4 commits into from
Sep 5, 2018
Merged

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Aug 31, 2018

This pull request incorporates the new puf.cps file generated by the changes in taxdata pull request 279. Those taxdata changes added two new variables (the amount contributed to defined-contribution (DC) pension plans by the taxpayer and pension contributions made by the spouse, which are named pencon_p and pencon_s, respectively). The new data variables required some revisions in payroll tax logic (because the payroll tax base includes pension contributions even thought the income tax base does not). And the pension contribution amounts are added into expanded_income causing changes in the distributional tables. Taken together, the new data and new logic cause many changes in the test results.

As a result of these data and associated logic changes, payroll tax liability is noticeably higher than before and income tax liability is essentially unchanged. So, for example, in 2018 payroll tax liability is up by $30.9 billion, which is a 2.7 percent increase, but income tax liability is unchanged when rounding to the nearest $0.1 billion.

Note that this pull request also adds the pencon_p and pencon_s variables to the CPS input data, but as of yet the values of those CPS variables are zero for each filing unit.

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #2056 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
+ Coverage   99.97%   99.97%   +<.01%     
==========================================
  Files          16       16              
  Lines        3528     3530       +2     
==========================================
+ Hits         3527     3529       +2     
  Misses          1        1
Impacted Files Coverage Δ
taxcalc/records.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676ad5b...3077fbe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants