Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from using pep8 to pycodestyle #1989

Merged
merged 5 commits into from
May 1, 2018
Merged

Switch from using pep8 to pycodestyle #1989

merged 5 commits into from
May 1, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Apr 30, 2018

This pull request follows the suggestion printed by pep8 version 1.7.1 and switches from using pep8 to pycodestyle. Here is the warning printed by version 1.7.1 of pep8:

tax-calculator$ pep8 taxcalc
/Users/mrh/anaconda2/lib/python2.7/site-packages/pep8.py:2124: UserWarning: 

pep8 has been renamed to pycodestyle (GitHub issue #466)
Use of the pep8 tool will be removed in a future release.
Please install and use `pycodestyle` instead.

$ pip install pycodestyle
$ pycodestyle ...

tax-calculator$ pep8 --version
/Users/mrh/anaconda2/lib/python2.7/site-packages/pep8.py:2124: UserWarning: 

pep8 has been renamed to pycodestyle (GitHub issue #466)
Use of the pep8 tool will be removed in a future release.
Please install and use `pycodestyle` instead.

$ pip install pycodestyle
$ pycodestyle ...

1.7.1

This pull request continues to use pep8 on GitHub because a needed package --- pytest-codestyle --- is not available as a conda package.

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #1989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1989   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3756    3756           
======================================
  Hits         3756    3756
Impacted Files Coverage Δ
taxcalc/parameters.py 100% <ø> (ø) ⬆️
taxcalc/growdiff.py 100% <ø> (ø) ⬆️
taxcalc/simpletaxio.py 100% <ø> (ø) ⬆️
taxcalc/records.py 100% <ø> (ø) ⬆️
taxcalc/policy.py 100% <ø> (ø) ⬆️
taxcalc/decorators.py 100% <ø> (ø) ⬆️
taxcalc/utilsprvt.py 100% <ø> (ø) ⬆️
taxcalc/taxcalcio.py 100% <ø> (ø) ⬆️
taxcalc/utils.py 100% <ø> (ø) ⬆️
taxcalc/growfactors.py 100% <ø> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3bdff2...d26f1d3. Read the comment docs.

@martinholmer martinholmer merged commit 9a0232a into PSLmodels:master May 1, 2018
@talumbau talumbau removed the ready label May 1, 2018
@martinholmer martinholmer deleted the pep8-renamed branch May 1, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants