Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_benefits=False optional argument to Records.cps_constructor #1985

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Add no_benefits=False optional argument to Records.cps_constructor #1985

merged 1 commit into from
Apr 27, 2018

Conversation

martinholmer
Copy link
Collaborator

The new argument provides Tax-Calculator users with the option of not including benefits information in the Records object. The default when calling recs_large = Records.cps_constructor() is to include benefits in the recs_large object. But if there is no need for benefits information, consider doing this recs_small = Records.cps_constructor(no_benefits=True) to not include benefits information in the recs_small object. The size difference in the two Records objects is considerable:

recs_small    482.5 MegaBytes
recs_large   3487.4 MegaBytes

@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #1985 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1985   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3738    3741    +3     
======================================
+ Hits         3738    3741    +3
Impacted Files Coverage Δ
taxcalc/records.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83f298...ed867ee. Read the comment docs.

@martinholmer martinholmer merged commit 696eaa9 into PSLmodels:master Apr 27, 2018
@martinholmer martinholmer deleted the no-benefits-option branch April 28, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants