Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for pending release 0.20.0 #1983

Merged
merged 16 commits into from
May 18, 2018
Merged

Update documentation for pending release 0.20.0 #1983

merged 16 commits into from
May 18, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request includes updates to the RELEASES.md file as well as user documentation and cookbook updates for the next Tax-Calculator release.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #1983 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1983   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          39       39           
  Lines        3836     3836           
=======================================
  Hits         3835     3835           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7088300...b675c9e. Read the comment docs.

@MaxGhenis
Copy link
Contributor

Is RELEASES.md intended to cover downstream changes from C-TAM? For example I don't see PSLmodels/C-TAM#66 in the 0.18.0 release or PSLmodels/C-TAM#65 in the 0.19.0 release. If so, PSLmodels/C-TAM#68 will also affect taxdata/taxcalc once fixed.

@martinholmer
Copy link
Collaborator Author

@MaxGhenis asked confusingly in the 0-20-0 branch about the 0.18.0 release:

Is RELEASES.md intended to cover downstream changes from C-TAM? For example I don't see PSLmodels/C-TAM#66 in the 0.18.0 release or PSLmodels/C-TAM#65 in the 0.19.0 release. If so, PSLmodels/C-TAM#68 will also affect taxdata/taxcalc once fixed.

The TANF benefits fix was included in 0.19.0 as part of the CPS age variables fix:
screen shot 2018-04-25 at 7 30 11 pm

From the 0.18.0 release notes:
screen shot 2018-04-25 at 7 15 28 pm

@MaxGhenis
Copy link
Contributor

I don't see the TANF PR (PSLmodels/taxdata#178) mentioned in #1962. The housing wording sounded like a logic change rather than a data change (I'd actually forgotten that was the reason behind the low values, but it's been a while now).

It sounds like the answer to my question is yes, that RELEASES.md intends to cover taxdata and C-TAM. I find this update really useful to catch up on other issues I'm not following as closely, so I'd guess adding detail on data changes would benefit other users, especially those not subscribed to the taxdata and/or C-TAM repos.

@martinholmer
Copy link
Collaborator Author

@MaxGhenis read this:

screen shot 2018-04-26 at 9 08 18 am

and the said:

The housing wording sounded like a logic change rather than a data change

I'm not sure how something listed under Bug Fixes that says the change was "in CPS data" can be interpreted as a "logic change." If there were any questions in your mind, they would have been answered if you had clicked on the link to pull request #1941. The links to the pull requests are there to provide more detail.

@martinholmer martinholmer removed the WIP label May 18, 2018
@martinholmer martinholmer merged commit 64e2e23 into PSLmodels:master May 18, 2018
@martinholmer martinholmer deleted the 0-20-0 branch May 19, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants