Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify datatype of parameters in JSON files #1970

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Clarify datatype of parameters in JSON files #1970

merged 1 commit into from
Apr 13, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Apr 13, 2018

This pull request tries to make the JSON parameter file values of integer_value and boolean_value less confusing.

Now, a boolean parameter has integer_value false and boolean_value true.
And an integer parameter has integer_value true and boolean_value false.
And a float parameter has integer_value false and boolean_value false.

The Tax-Calculator tests have been changed to enforce this new approach and the source code has been modified to handle the new pattern of values.

These changes do imply a change in the user documentation, but they cause no changes in test results or calculated tax results.

Thanks to @hdoupe for pointing out the need for these changes in his extensive work on pull request #1952.

@codecov-io
Copy link

codecov-io commented Apr 13, 2018

Codecov Report

Merging #1970 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1970   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3756    3762    +6     
======================================
+ Hits         3756    3762    +6
Impacted Files Coverage Δ
taxcalc/parameters.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796a91c...63f38ef. Read the comment docs.

@martinholmer martinholmer merged commit 8518f5f into PSLmodels:master Apr 13, 2018
@talumbau talumbau removed the ready label Apr 13, 2018
@martinholmer martinholmer deleted the change-param-types branch April 15, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants