Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen type checking of reform parameters #1960

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Strengthen type checking of reform parameters #1960

merged 2 commits into from
Apr 9, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Apr 8, 2018

This pull request attempts to resolve the bug report by @hdoupe in issue #1956.
It does so in a way that strengthens the type checking of all parameters (boolean, integer and float) in a reform dictionary passed to the Policy class implement_reform method.

@codecov-io
Copy link

codecov-io commented Apr 8, 2018

Codecov Report

Merging #1960 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1960   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3748    3756    +8     
======================================
+ Hits         3748    3756    +8
Impacted Files Coverage Δ
taxcalc/policy.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4a3ea...6fb3929. Read the comment docs.

@martinholmer martinholmer added ready and removed ready labels Apr 8, 2018
@hdoupe
Copy link
Collaborator

hdoupe commented Apr 9, 2018

@martinholmer this looks good to me.

@martinholmer
Copy link
Collaborator Author

@hdoupe, Thanks for the review. Merging now.

@martinholmer martinholmer merged commit 36e749a into PSLmodels:master Apr 9, 2018
@talumbau talumbau removed the ready label Apr 9, 2018
hdoupe pushed a commit to hdoupe/Tax-Calculator that referenced this pull request Apr 9, 2018
@martinholmer martinholmer deleted the fix-1956 branch April 15, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants