Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline dependent-credit logic and update documentation #1937

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Streamline dependent-credit logic and update documentation #1937

merged 2 commits into from
Mar 30, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request streamlines dependent-credit logic by eliminating a redundant policy parameter (_DependentCredit_c) and simplifying the dependent credit phase-out calculations. It also updates the documentation of the policy parameters related to the dependent credit and adds documentation to the records_variables.json file for the dep_credit calculated variable.

Simplifying the dependent-credit phase-out logic changes the 2018 CPS estimate of Child Tax Credit plus Dependent Credit from $132.138 billion to $132.397 billion, which is an increase of one-fifth of one percent.

@codykallen and @MattHJensen and others with an interest, please review the changes in this pull request to make sure that the new code and documentation correctly represent dependent-credit phase-out logic.

@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #1937 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1937   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3629    3629           
======================================
  Hits         3629    3629
Impacted Files Coverage Δ
taxcalc/calculate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f18ab...e77e322. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants