Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 2.7 sunset message to Calculator constructor #1923

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Add Python 2.7 sunset message to Calculator constructor #1923

merged 1 commit into from
Mar 16, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request notifies Tax-Calculator users that beginning in 2019 Python 2.7 will not be supported: the source code will be Python 3.6 and conda taxcalc packages will be available only for Python 3.6.

The user documentation already instructs users to install Python 3.6 (and not 2.7) and the contributor guide already says the same thing. And the developers of projects that are known to use Tax-Calculator have been directly notified of this future change. So, we have given a comprehensive early warning of this major change.

@martinholmer martinholmer changed the title Add Python 2,7 sunset message to Calculator constructor Add Python 2.7 sunset message to Calculator constructor Mar 14, 2018
@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #1923 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1923   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3588    3594    +6     
======================================
+ Hits         3588    3594    +6
Impacted Files Coverage Δ
taxcalc/calculate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d44a7d5...9aafe89. Read the comment docs.

@MattHJensen
Copy link
Contributor

LGTM. Thanks @martinholmer.

@MattHJensen MattHJensen merged commit fa0d040 into PSLmodels:master Mar 16, 2018
@martinholmer martinholmer deleted the python27-sunset branch March 16, 2018 20:12
@MaxGhenis
Copy link
Contributor

Do you know if it's possible to warn upon loading the package? I couldn't find a way with a cursory search, but this would be nice for users who create many Calculator objects in the same session (like me...) and get warned multiple times.

@martinholmer
Copy link
Collaborator Author

@MaxGhenis asked:

Do you know if it's possible to warn upon loading the package? I couldn't find a way with a cursory search, but this would be nice for users who create many Calculator objects in the same session (like me...) and get warned multiple times.

No I don't know how to do that. But if you are getting tired of reading the warning and don't want to get rid of it by upgrading to Python 3.6, then simply set verbose=False in the Calculator class constructor. That should suppress the warning.

@MaxGhenis
Copy link
Contributor

MaxGhenis commented Mar 16, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants