-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Calculator decile_graph method to use new distribution table #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1918 +/- ##
======================================
Coverage 100% 100%
======================================
Files 38 38
Lines 3605 3625 +20
======================================
+ Hits 3605 3625 +20
Continue to review full report at Codecov.
|
LGTM. Thanks very much @martinholmer and everyone who participated in the discussion that led here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request revises the
Calculator.decile_graph
method to allow graphing of the bottom decile to include or not those filing units with zeroexpanded_income
and to include or not those filing units with negativeexpanded_income
. This approach leaves it up to the Tax-Calculator user how to display the percentage change in after-tax expanded income for the bottom decile in the graph.Given the new method, the following script (which uses the same reform as in #1917) produces the following four graphs:
Here is the graph when using CPS input data and including all the zeros and negatives in the bottom decile:
Here is the graph when using CPS input data and excluding all the zeros and negatives in the bottom decile:
Here is the graph when using PUF input data and including all the zeros and negatives in the bottom decile:
And here is the graph when using PUF input data and excluding all the zeros and negatives in the bottom decile: