The tbi run_nth_year_tax_calc_model function now returns full tables

[martinholmer]

This pull request standardizes the tables generated by the TaxBrain Interface (tbi) so that the full table is always returned by the run_nth_year_tax_calc_model function. Beginning with this pull request, all the table rows generated by the Calculator create table methods (whether using deciles and bins) are returned by the run_nth_year_tax_calc_model function. TaxBrain can then decide whether to show all of the table or only part of the table.

[codecov-io]

Codecov Report

Merging #1914 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1914   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3603    3603           
======================================
  Hits         3603    3603

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e471bdc...6905c55. Read the comment docs.

[MattHJensen]

@hdoupe may want to take a look.

[hdoupe]

Thanks for tagging me in this PR.

@martinholmer can you leave this open until the end of day on Monday so that I can run this against PolicyBrain?

[martinholmer]

@hdoupe asked the following about Tax-Calculator pull request #1914:

Can you leave [1914] open until the end of day on Monday so that I can run this against PolicyBrain?

Sure. I'm in no rush. I'm waiting for pull request #1909 to be ready for review.

While the changes in #1909 and #1914 would, in theory, take just a little programming at your end, it would appear you need to rework the TaxBrain handling of Tax-Calculator tables in a much broader way. I'm guessing that given the following two observations:

1. Tax-Calculator has been for many months producing in the difference table the percentage-change-in-aftertax-income statistic, but it has never been displayed by TaxBrain. That statistic is key for any repeal-benefits-and-add-UBI reforms, so you would have needed to do work on the display of tables this month even if pull request The tbi run_nth_year_tax_calc_model function now returns full tables #1914 did not exist. I reported this TaxBrain problem in PolicyBrain issue 770 back in December.

2. The distribution table is missing key statistics as reported in PolicyBrain issue 771.

Here is what the current version of TaxBrain shows for the difference table.

@MattHJensen @GoFroggyRun

[martinholmer]

@hdoupe, Instead of testing #1914, you should test #1917, which contains all the changes in #1914 plus adds a new row to both the distribution table and the difference table.

[martinholmer]

@hdoupe said in PolicyBrain pull request 846:

This PR updates to the tables specified in #1917. The update is fairly straight forward. The table labels still need to be updated. For now, they are just the variable names.

Pull request #1917 includes all the code changes in #1914.