Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct WEBBIN_ROW_NAMES for bottom bin shown by TaxBrain #1889

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Correct WEBBIN_ROW_NAMES for bottom bin shown by TaxBrain #1889

merged 1 commit into from
Feb 17, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request resolves PolicyBrain issue 214 by changing the first name in the WEBBIN_ROW_NAMES list from <$0K to $0-10K. And because the dropping of the bin containing filing units with negative income is something done only for TaxBrain, the WEBBIN_ROW_NAMES list has been moved from taxcalc/utils.py to taxcalc/tbi/tbi.py. This move means that TaxBrain will have to import the corrected WEBBIN_ROW_NAMES list from tbi not from utils.

@hdoupe @Amy-Xu

@codecov-io
Copy link

codecov-io commented Feb 17, 2018

Codecov Report

Merging #1889 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1889   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3301    3301           
======================================
  Hits         3301    3301
Impacted Files Coverage Δ
taxcalc/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044bb80...175c067. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returns on each row do not sum up to total
2 participants