Add quintile graph to tc --graphs output #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 3213 3301 +88
======================================
+ Hits 3213 3301 +88
Continue to review full report at Codecov.
|
This was referenced Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
quintile_graphmethod to Calculator class and two associated utility functions. Also, include the quintile graph in the output generated by thetc --graphsoption.This enhancement is being added to resolve issue #1806 which highlighted the fact that negative aggregate expanded income in the bottom decile produced misleading (but accurate) decile graphs of percentage change in after-tax expanded income. Since issue #1806 was raised new CPS data have been introduced that allow the inclusion of the consumption value of benefits provided by several benefit programs in expanded income. This CPS data enhancement has made aggregate expanded income in the bottom decile positive, which eliminates the potentially misleading graphical result. However, using the decile graph with PUF data can still produce misleading (but accurate) decile graphs.
The quintile graph is the same as the decile graph except that it uses percentile groups that are twice as big as used in the decile graph. The bottom quintile has positive aggregate expanded income and so it is not possible the produce misleading quintile graphs with either PUF or CPS input data.