Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new 2011 PUF data in Tax-Calculator #1871

Merged
merged 13 commits into from
Feb 13, 2018
Merged

Use new 2011 PUF data in Tax-Calculator #1871

merged 13 commits into from
Feb 13, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Feb 11, 2018

Merged taxdata pull request 114 and merged taxdata pull request 150 --- both the work of @andersonfrailey --- together create a new puf.csv file and new puf_weights.csv and puf_ratios.csv files. The growfactors.csv file generated by taxdata 114 has been replaced in this pull request by a hand-edited growfactors.csv file that has the same values as on the Tax-Calculator master branch for the years 2012+. (The taxdata version of growfactors.csv is conceptually the same but contains very small differences in the 2012+ growfactor values that generate many failures in unit tests that use CPS input data. The hand-edited version leaves all the CPS results unchanged.)

Using these four new data files, all the CPS-related unit tests continue to pass and, as expected, the PUF-related unit tests produces slightly different results than were generated using the older 2009 PUF data.

This pull request has used the puf.csv file generated by taxdata pull request 150 that has the following characteristics:

File size = 54714632 bytes
MD5 = de4a59c9bce0a7d5e6c3110172237c9b

@codecov-io
Copy link

codecov-io commented Feb 11, 2018

Codecov Report

Merging #1871 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1871   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3211    3207    -4     
======================================
- Hits         3211    3207    -4
Impacted Files Coverage Δ
taxcalc/filings/forms/us8863.py 100% <ø> (ø) ⬆️
taxcalc/records.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a5502c...ab6f0cf. Read the comment docs.

@martinholmer martinholmer merged commit 0f718eb into PSLmodels:master Feb 13, 2018
@martinholmer martinholmer deleted the new-puf-data branch February 13, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants