Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tc --baseline option and associated logic and documentation #1851

Merged
merged 7 commits into from
Jan 30, 2018
Merged

Add tc --baseline option and associated logic and documentation #1851

merged 7 commits into from
Jan 30, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jan 28, 2018

This pull request adds a --baseline BASELINE option to the command-line tool tc. Without this option, tc uses current-law policy as the baseline. When using this option, tc uses the reform specified in the BASELINE JSON reform file as the baseline.

The most common use of this new capability (at least in the near future) will probably be to engage in counter-factual history: what if some other reform (other than TCJA) had been enacted in late 2017. Such an analysis would use the new option this way:
--baseline 2017_law.json
and then specify the alternative reform using the --reform option this way:
--reform 2017_law.json+alternative_reform.json

This pull request resolves enhancement-request issue #1770.

@martinholmer martinholmer changed the title Add tc --baseline option without associated logic Add tc --baseline option and associated logic and documentation Jan 29, 2018
@codecov-io
Copy link

codecov-io commented Jan 29, 2018

Codecov Report

Merging #1851 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1851   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3141    3162   +21     
======================================
+ Hits         3141    3162   +21
Impacted Files Coverage Δ
taxcalc/taxcalcio.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98bc86...b0362dc. Read the comment docs.

@martinholmer martinholmer added ready and removed WIP labels Jan 29, 2018
@martinholmer martinholmer merged commit b36df22 into PSLmodels:master Jan 30, 2018
@martinholmer martinholmer deleted the tc-baseline-option branch January 30, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants