Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _ALD_AlimonyReceived_hc policy parameter and logic #1818

Merged
merged 5 commits into from
Jan 11, 2018
Merged

Add _ALD_AlimonyReceived_hc policy parameter and logic #1818

merged 5 commits into from
Jan 11, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jan 10, 2018

This pull request attempts to resolve issue #1815, which was raised by @codykallen.

@codykallen (and others) please review these changes to make sure they make sense.

These changes assume the timing of the changes in ALD treatment of alimony received under TCJA are the same as the timing of the changes in ALD treatment of alimony paid. But I don't really know that. Can anybody confirm the validity of this assumption? If that assumption is false, what is the timing of the changes in ALD treatment of alimony received under TCJA?

@codykallen
Copy link
Contributor

@martinholmer, can you clarify what you mean by timing?

@martinholmer
Copy link
Collaborator Author

@codykallen, Just look at the proposed changes to the TCJA_Reconciliation.json file. Are they correct?

@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

Merging #1818 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1818   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3058    3058           
======================================
  Hits         3058    3058

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d9d81...814da53. Read the comment docs.

@codykallen
Copy link
Contributor

@martinholmer, the alimony provisions both take effect beginning in 2019.

@martinholmer
Copy link
Collaborator Author

@codykallen said:

the alimony provisions both take effect beginning in 2019

Good. That's the way it is in the PR. Thanks for checking. So does this PR look OK to you?

@codykallen
Copy link
Contributor

Looks good to me.

@martinholmer martinholmer merged commit 2af32da into PSLmodels:master Jan 11, 2018
@martinholmer martinholmer deleted the alimony-received branch January 11, 2018 17:15
martinholmer added a commit that referenced this pull request Jan 12, 2018
Update values for several policy parameters added in #1818 and #1819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants