-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making things "pythonic" #17
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rough translation
namesCap = [str.upper(n) if str.isalpha(n) else n for n in names] | ||
# This should be dealt with so that we don't keep referencing the same array | ||
# simply find all uses of this and figure out if they're called for (mostly not) | ||
DIMARRAY = np.zeros((139651,)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is sketchy (basically all subsequent np.zeros() arrays are just referencing this one), but it's here to purposefully draw our attention to cases where we've been using np.zeros() and make us revisit them critically.
This is stale, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a biggish update from me (mostly addressing #10 and #11) and I would like to discuss a couple of things in it before you merge my changes into the master branch. Treat this not just as a finished product, but as a work in progress. Please do take advantage of commenting on specific lines (git lets you do that, hurrah!), I'm looking forward to your feedback.
I've worked on the following stuff: