Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Calculator usage in unit tests #1588

Merged
merged 10 commits into from
Oct 17, 2017
Merged

Revise Calculator usage in unit tests #1588

merged 10 commits into from
Oct 17, 2017

Conversation

martinholmer
Copy link
Collaborator

The changes in this pull request build on the changes in pull request #1582. As mentioned in #1582, those changes allow a simpler idiom for creating current-law and reform Calculator objects. The changes in this pull request implement that simpler idiom in the unit tests. There are no changes to the scope or substance of the tests and there are no changes to tax-calculating logic or results.

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #1588 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1588   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2743    2738    -5     
======================================
- Hits         2743    2738    -5
Impacted Files Coverage Δ
taxcalc/calculate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20aee9b...fd75921. Read the comment docs.

@martinholmer martinholmer merged commit 30c4567 into PSLmodels:master Oct 17, 2017
@martinholmer martinholmer deleted the revise-calculator-usage branch October 17, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants