Return a dictionary (not a tuple) from dropq run_nth_year_tax_calc_model #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholmer
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1543 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 2558 2559 +1
======================================
+ Hits 2558 2559 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1537, this pull request changes the dropq
run_nth_year_tax_calc_modelfunction so that it returns a dictionary of results tables (rather than an unnamed tuple of results tables). There are no changes in tax-calculation results, just a less risky way of returning complex data.@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @brittainhard