Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_dropq_diff_vs_util_diff to test_dropq.py #1531

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Add test_dropq_diff_vs_util_diff to test_dropq.py #1531

merged 2 commits into from
Aug 28, 2017

Conversation

martinholmer
Copy link
Collaborator

Add a test the checks that that difference that generated by the create_difference_table utility function and the dropq_diff_table function have the same values when skipping the actual dropq records-dropping logic.

This pull request involves no change in logic or results, it just adds a new test.

@codecov-io
Copy link

Codecov Report

Merging #1531 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1531   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2565    2565           
======================================
  Hits         2565    2565

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6257250...4afcf1b. Read the comment docs.

@martinholmer martinholmer merged commit 70fbc0b into PSLmodels:master Aug 28, 2017
@martinholmer martinholmer deleted the add-dropq-diff-test branch August 28, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants