[WIP] Add After-Tax Income Percent Change column to dropq results

[andersonfrailey]

In PR #1375, I added a feature to include the percent change in after tax income in the difference table. @hdoupe and I are trying to add it to TaxBrain as well and the purpose of this PR is primarily to solicit help. We believe that one of the first steps is to modify dropq.py and dropq_utils.py, as shown in this PR. Any help progressing from this point would be appreciated.

[codecov-io]

Codecov Report

Merging #1521 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1521   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2557    2557           
======================================
  Hits         2557    2557

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e981d56...7d22eb8. Read the comment docs.

[martinholmer]

@andersonfrailey, It's good your asking for review on changes to dropq code. The current and past staff at Continuum Analytics are the best people to review this.

@brittainhard @talumbau

[martinholmer]

@andersonfrailey,
I know this is a Work In Progress, but the proposed changes don't seem to work. When I run the py.test suite of unit tests on this pull request, I get seven test failures. The most frequent reason for the failures is this error:

E   KeyError: 'aftertax_perc'

Is this not a complete pull request?

[andersonfrailey]

@martinholmer asked:

Is this not a complete pull request?

It's a start to one. I'm also getting error when I run py.test, but I wanted to get some feedback from other contributors about how to make this work with TaxBrain.

[martinholmer]

@andersonfrailey said:

[PR#1521 is not complete yet,] but I wanted to get some feedback from other contributors about how to make this work with TaxBrain.

Good to get feedback, but eventually what you add to Tax-Calculator in support of TaxBrain will need to work with the rest of Tax-Calculator. Why not get that part of the puzzle solved now while you wait for feedback from the TaxBrain developers?

[martinholmer]

The goal of pull request #1521 has been achieved by pull request #1537.