-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round inflated parameter values to nearest cent #1506
Round inflated parameter values to nearest cent #1506
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1506 +/- ##
==========================================
+ Coverage 99.96% 99.96% +<.01%
==========================================
Files 37 37
Lines 2553 2557 +4
==========================================
+ Hits 2552 2556 +4
Misses 1 1
Continue to review full report at Codecov.
|
I had to add a temporary @xfail decorator to test_agg in the |
The improved difference reporting in |
This pull request rounds each wage-inflated and price-inflated policy parameter value to the nearest cent. This rounding is done each time a parameter's value for a year is inflated from that parameter's value in the prior year. This change causes a few rounding errors in a couple of years for some intermediate tax results. There are no changes in any tax liability amounts (which have always been rounded to the nearest one-tenth of a billion dollars) and no changes in the marginal tax rate histogram counts.
This change is being made to simplify TaxBrain programming in the spirit of the approach advocated by @talumbau in TaxBrain issue 596.
@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @codykallen
@brittainhard @PeterDSteinberg