-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes caused by using variables in taxdata add-k1bx14 branch #1438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1438 +/- ##
==========================================
+ Coverage 99.71% 99.71% +<.01%
==========================================
Files 40 40
Lines 2786 2788 +2
==========================================
+ Hits 2778 2780 +2
Misses 8 8
Continue to review full report at Codecov.
|
When using the new While these changes have only modest effects on current-law policy estimates, they are important changes for any analysis of the revenue effects of relabeling income under tax reforms that lower tax rates on self-employment income generated by partnerships and S corporations below tax rates on wage and salary income. See, for example, Neil Irwin's 4/28/2017 New York Times article entitled "Under the Trump Tax Plan, We Might All Want to Become Corporations," which is here. |
The paired taxdata pull request 107 and taxcalc pull request 1438 are now ready for review. I'm particularly interested in comments about whether or not the documentation (in the revised |
@codykallen, I'm hoping you can review the logic changes in Tax-Calculator pull request #1438. |
@martinholmer asked about pending pull request #1438:
Here is a summary of a private email exchange on this matter. @martinholmer said:
@feenberg responded:
|
This pull request contains changes in Tax-Calculator logic associated with the revised and new variables generated by taxdata pull request 107.
These Tax-Calculator changes, along with the changes in taxdata pull request 107, are meant to resolve the Tax-Calculator bug described in Tax-Calculator issue 1436.