Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --test option to tc CLI #1306

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Add --test option to tc CLI #1306

merged 1 commit into from
Apr 21, 2017

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Apr 21, 2017

This pull request add an installation test to the tc CLI.
NOTE that this enhancement was refined by two subsequent commits: d571c82 and 63595c2
No change in tax calculation logic or test results.

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #1306 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1306   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          38       38           
  Lines        2878     2878           
=======================================
  Hits         2868     2868           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3832b...f3d087e. Read the comment docs.

@martinholmer martinholmer merged commit ba873e2 into PSLmodels:master Apr 21, 2017
@MattHJensen
Copy link
Contributor

MattHJensen commented Apr 21, 2017 via email

@martinholmer
Copy link
Collaborator Author

@MattHJensen said about the tc CLI installation test:

This is nice!

Just one of the things recommended by Karl Fogel in his book, Producing Open Source Software: How to Run a Successful Free Software Project. Thanks for recommending the book!

@MattHJensen MattHJensen mentioned this pull request Apr 26, 2017
@martinholmer martinholmer deleted the cli-test-option branch April 26, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants