Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional haircuts for deductions and credits #1247

Merged
merged 2 commits into from
Mar 16, 2017

Conversation

andersonfrailey
Copy link
Collaborator

This PR adds additional haircut options for a number of credits and deductions and fixes a minor error in the UBI function's docstring. There was nothing in the naming convention regarding what to name variables related to credits in this situation so I went with CR to start the haircut variables applied to credits. I'm happy to change that if there is consensus on a better option.

The point is to allow a user to repeal credits and all above the line deductions. Here are the new haricuts and what they are applied to:

Variable Description Type functions Hair Cut
e07240 Retirement Saving Credit Credit NonRefundable Credits _CR_RetirementSavings_hc
e07300 Foreign Tax Credit Credit NonRefundable Credits _CR_ForeignTax_hc
e07260 Residential Energy Credit Credit NonRefundable Credits _CR_ResidentialEnergy_hc
e07400 General Business Credit Credit NonRefundable Credits _CR_GeneralBusiness_hc
e07600 Prior Year Minimum Tax Credit Credit NonRefundable Credits _CR_MinimumTax_hc
c10960 American Opportunity Credit - Refundable Credit NonRefundable Credits, AmOppParts _CR_AmOppRefundable_hc
c87668 American Opportunity Credit - NonRefundable Credit NonRefundable Credits, AmOppParts _CR_AmOppNonRefundable_hc
c07200 Schedule R Credit NonRefundable Credits, SchR _CR_SchR_hc
p08000 Other Credits Credit NonRefundable Credits _CR_OtherCredits_hc
e03220 Educator Expenses Deduction Deduction Adj _ALD_EducatorExpenses_hc
e03290 HSA Deduction Deduction Adj _ALD_HSADeduction_hc
e03150 Total Deductable IRA plan contributions Deduction Adj _ALD_IRAContributions_hc
e03240 Domestic Production Activity Deduction Deduction Adj _ALD_DomesticProduction_hc
e03230 Tuition and Fees Deduction Adj _ALD_Tuition_hc

@MattHJensen @martinholmer

@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #1247 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1247   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          38       38           
  Lines        2705     2705           
=======================================
  Hits         2685     2685           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a963067...39fd26f. Read the comment docs.

@martinholmer
Copy link
Collaborator

@andersonfrailey, Thanks for all the new policy parameters in pull request #1247.
I've looked this over and run it through my test suite and it all seems good.

Unless you have any other changes you want to make, I'll merge #1247 into master later this morning. Let me know if #1247 is finished or if you plan additional changes.

@andersonfrailey
Copy link
Collaborator Author

@martinholmer, nothing more to add in this PR. Thanks for looking it over!

@martinholmer martinholmer merged commit 4076f70 into PSLmodels:master Mar 16, 2017
@MattHJensen MattHJensen mentioned this pull request Mar 17, 2017
@MattHJensen MattHJensen mentioned this pull request Mar 24, 2017
@andersonfrailey andersonfrailey deleted the haircuts branch July 20, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants