-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move simtax code and test to taxcalc/validation/taxsim directory #1228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
+ Coverage 98.93% 99.22% +0.29%
==========================================
Files 39 38 -1
Lines 2997 2719 -278
==========================================
- Hits 2965 2698 -267
+ Misses 32 21 -11
Continue to review full report at Codecov.
|
In addition to moving all simtax-related code and tests to the taxcalc/validation/taxsim directory, pull request #1228 switches from relative imports to absolute imports because the use of relative imports is strongly discouraged in the Python community. Here is one example (a 2013 post on GitHub):
See also this StackOverflow discussion of import style. |
This pull request moves the
simtax.py
,simpletaxio.py
andtest_simpletaxio.py
files to the taxcalc/validation/taxsim directory, which is the only place they are used (for Tax-Calculator validation against Internet TAXSIM).@MattHJensen @feenberg @Amy-Xu @andersonfrailey @GoFroggyRun @codykallen @zrisher