Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move simtax code and test to taxcalc/validation/taxsim directory #1228

Merged
merged 10 commits into from
Mar 8, 2017
Merged

Move simtax code and test to taxcalc/validation/taxsim directory #1228

merged 10 commits into from
Mar 8, 2017

Conversation

martinholmer
Copy link
Collaborator

This pull request moves the simtax.py, simpletaxio.py and test_simpletaxio.py files to the taxcalc/validation/taxsim directory, which is the only place they are used (for Tax-Calculator validation against Internet TAXSIM).

@MattHJensen @feenberg @Amy-Xu @andersonfrailey @GoFroggyRun @codykallen @zrisher

@codecov-io
Copy link

codecov-io commented Mar 7, 2017

Codecov Report

Merging #1228 into master will increase coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   98.93%   99.22%   +0.29%     
==========================================
  Files          39       38       -1     
  Lines        2997     2719     -278     
==========================================
- Hits         2965     2698     -267     
+ Misses         32       21      -11
Impacted Files Coverage Δ
taxcalc/filings/forms/us6251.py 100% <100%> (ø)
taxcalc/filings/forms/us1040sse.py 100% <100%> (ø)
taxcalc/filings/forms/us1040sr.py 100% <100%> (ø)
taxcalc/filings/forms/us4952.py 100% <100%> (ø)
taxcalc/policy.py 100% <100%> (ø)
taxcalc/records.py 99.1% <100%> (ø)
taxcalc/init.py 100% <100%> (ø)
taxcalc/dropq/dropq.py 100% <100%> (ø)
taxcalc/filings/forms/us4137.py 100% <100%> (ø)
taxcalc/filings/forms/us1040.py 100% <100%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfeca30...bcb5fc6. Read the comment docs.

@martinholmer
Copy link
Collaborator Author

martinholmer commented Mar 8, 2017

In addition to moving all simtax-related code and tests to the taxcalc/validation/taxsim directory, pull request #1228 switches from relative imports to absolute imports because the use of relative imports is strongly discouraged in the Python community.

Here is one example (a 2013 post on GitHub):

PEP 8 says: "Relative imports for intra-package imports are highly discouraged.
Always use the absolute package path for all imports. Even now that PEP 328
is fully implemented in Python 2.5, its style of explicit relative imports is 
actively discouraged; absolute imports are more portable and usually more readable."

See also this StackOverflow discussion of import style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants