Add Appveyor scripts #1111

talumbau · 2016-12-20T19:56:02Z

No description provided.

codecov-io · 2016-12-20T20:12:08Z

Current coverage is 98.84% (diff: 100%)

Merging #1111 into master will increase coverage by 0.04%

@@             master      #1111   diff @@
==========================================
  Files            38         38          
  Lines          2830       2932   +102   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2796       2898   +102   
  Misses           34         34          
  Partials          0          0

Powered by Codecov. Last update 3d24438...a95d9ed

martinholmer · 2016-12-20T20:23:28Z

@talumbau, Are the Travis-CI processes and the AppVeyor process going to run simultaneously? I certainly hope so because the check-in testing already takes too long.

talumbau · 2016-12-20T20:28:41Z

yes they are different services provided by different companies. They are both free for open source projects.

martinholmer · 2016-12-20T21:23:43Z

@talumbau said:

yes they are different services provided by different companies. They are both free for open source projects.

I don't really care about the term of use. My question is this: when I submit a pull request are the three Travis-CI processes and the AppVeyor process(es) going to start at the same time and run in parallel?

- handle the fact the np.dype('i4') == int (Python native int) on Windows machines. This messes up the logic in the format_print function

talumbau · 2016-12-20T22:20:57Z

Github will notify both services at essentially the same time. Both services support the idea of "run these scripts on a virtual machine." Both services, therefore, need to be assigned a cloud instance for running the tests. Appveyor uses cloud machines provided by MS Azure. Travis CI uses cloud machines provided by AWS. If one service is experiencing a much heavier load than the other, they will not start at the same time, because one service will receive its virtual machine sooner than the other. There is no coordination between the services.

talumbau · 2016-12-20T22:21:55Z

Resolves #1086 via dced001

zrisher · 2016-12-21T01:28:07Z

The fix for #1086 via dced001 looks great, 👍 .

@talumbau The provision of automated testing for Windows would also be awesome. Would it be possible, though, to use the dependencies declared in environment.yml instead of declaring them within the build script itself, e.g. continuous_integration/setup_conda_environment.cmd:L16-26? Otherwise we're introducing for Windows the same problem you fixed for Linux in #1100.

talumbau · 2016-12-21T02:12:26Z

@talumbau The provision of automated testing for Windows would also be awesome. Would it be possible, though, to use the dependencies declared in environment.yml instead of declaring them within the build script itself, e.g. continuous_integration/setup_conda_environment.cmd:L16-26? Otherwise we're introducing for Windows the same problem you fixed for Linux in #1100.

Yes I agree. This was mostly a copy/paste job from an existing project. I think I can do that. If it is more difficult than it seems, I'll update here and see if doing that in a follow-up PR would be ok.

martinholmer · 2016-12-21T15:02:58Z

@talumbau, When do you expect to merge pull request #1111?

talumbau · 2016-12-21T21:03:31Z

I will try to do as @zrisher suggests (create environment purely from the environment.yml) some time today. If that is successful, then hopefully this can get merged today. If it's nontrivial, other's can comment if they would like to wait for the proper fix, or would rather we merge this and work on a follow-up after that.

talumbau · 2016-12-21T22:17:27Z

@zrisher have a look at 649d395

I think that makes it so that on both AppVeyor and Travis CI, the config is done from environment.yml. If you are satisfied, I think we can merge.

zrisher

Can we remove these lines too? Otherwise big 👍 on merging.

zrisher · 2016-12-22T06:32:23Z

continuous_integration/setup_conda_environment.cmd

-@rem Install optional dependencies for tests
-%CONDA_INSTALL% numpy=%NUMPY% pandas=%PANDAS% 
-%CONDA_INSTALL% numba bokeh=0.12.3 toolz six mock pep8 pylint
+%CONDA% env update -f environment.yml

 %PIP_INSTALL% pytest-pep8


@talumbau This is handled by environment.yml:

- pip: - pytest-pep8

So we can remove it here, correct?

zrisher · 2016-12-22T06:33:34Z

continuous_integration/setup_conda_environment.cmd


 %PIP_INSTALL% pytest-pep8

-if %PYTHON% LSS 3.0 (%PIP_INSTALL% git+https://github.com/Blosc/castra)
 if %PYTHON% LSS 3.0 (%PIP_INSTALL% backports.lzma mock)


@talumbau mock is installed via environment.yml. Do we need backports.lzma for Python < 3.0 on Windows? If so, should we include it in the environment file?

- remove manual install of mock - remove manual install of pytest-pep8

talumbau · 2016-12-29T17:28:22Z

@zrisher I removed the additional external dependencies that you found, thanks! I think this is good to go.

zrisher · 2016-12-29T19:52:48Z

@talumbau Nice! 👍

Add Appveyor scripts

0da4359

talumbau added the in progress label Dec 20, 2016

"pylist" -> "pylint"

28649b4

Adjust type comparison for Windows

dced001

- handle the fact the np.dype('i4') == int (Python native int) on Windows machines. This messes up the logic in the format_print function

talumbau mentioned this pull request Dec 20, 2016

Introductory py.test failing #1086

Closed

talumbau mentioned this pull request Dec 21, 2016

Reorganize parameters -- will facilitate TaxBrain updates #1109

Merged

appveyor environment comes from environment.yml

649d395

zrisher suggested changes Dec 22, 2016

View reviewed changes

Remove external dependencies in AppVeyor scripts

a95d9ed

- remove manual install of mock - remove manual install of pytest-pep8

talumbau merged commit 438cd20 into PSLmodels:master Dec 29, 2016

talumbau removed the in progress label Dec 29, 2016

martinholmer mentioned this pull request Jan 1, 2017

Change param_code to have multiple-statement (rather than single-expression) format #1107

Merged

MattHJensen mentioned this pull request Jan 2, 2017

Release 0.7.3 #1085

Closed

martinholmer mentioned this pull request Jan 22, 2019

AppVeyor testing on Windows has stopped working #2204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Appveyor scripts #1111

Add Appveyor scripts #1111

talumbau commented Dec 20, 2016

codecov-io commented Dec 20, 2016 •

edited

Loading

martinholmer commented Dec 20, 2016

talumbau commented Dec 20, 2016

martinholmer commented Dec 20, 2016

talumbau commented Dec 20, 2016

talumbau commented Dec 20, 2016

zrisher commented Dec 21, 2016 •

edited

Loading

talumbau commented Dec 21, 2016

martinholmer commented Dec 21, 2016

talumbau commented Dec 21, 2016

talumbau commented Dec 21, 2016

zrisher left a comment

zrisher Dec 22, 2016

zrisher Dec 22, 2016

talumbau commented Dec 29, 2016

zrisher commented Dec 29, 2016 •

edited

Loading

Add Appveyor scripts #1111

Add Appveyor scripts #1111

Conversation

talumbau commented Dec 20, 2016

codecov-io commented Dec 20, 2016 • edited Loading

Current coverage is 98.84% (diff: 100%)

martinholmer commented Dec 20, 2016

talumbau commented Dec 20, 2016

martinholmer commented Dec 20, 2016

talumbau commented Dec 20, 2016

talumbau commented Dec 20, 2016

zrisher commented Dec 21, 2016 • edited Loading

talumbau commented Dec 21, 2016

martinholmer commented Dec 21, 2016

talumbau commented Dec 21, 2016

talumbau commented Dec 21, 2016

zrisher left a comment

Choose a reason for hiding this comment

zrisher Dec 22, 2016

Choose a reason for hiding this comment

zrisher Dec 22, 2016

Choose a reason for hiding this comment

talumbau commented Dec 29, 2016

zrisher commented Dec 29, 2016 • edited Loading

codecov-io commented Dec 20, 2016 •

edited

Loading

zrisher commented Dec 21, 2016 •

edited

Loading

zrisher commented Dec 29, 2016 •

edited

Loading